Skip to content

Conversation

@SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 22, 2025

Fixes #4219

Changes proposed in this pull request:

  • Makes the LabelValue component always available to import in sync mode.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner August 22, 2025 11:12
@luceos luceos self-requested a review August 23, 2025 15:43
@imorland imorland added this to the 2.0.0-beta.4 milestone Oct 17, 2025
@imorland imorland merged commit 83318e5 into 2.x Oct 17, 2025
28 checks passed
@imorland imorland deleted the sm/4219 branch October 17, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Make sure all common JS components, etc... are accessible

3 participants